Skip to content

chore(services) rename visit to visitNode as visit was given an error #2505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Basarat Ali Syed (basarat) wants to merge 1 commit into from
Closed

chore(services) rename visit to visitNode as visit was given an error #2505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/services/services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ module ts {
let sourceFile = this;
let namedDeclarations: Declaration[] = [];

forEachChild(sourceFile, function visit(node: Node): void {
forEachChild(sourceFile, function visitNode(node: Node): void {
switch (node.kind) {
case SyntaxKind.FunctionDeclaration:
case SyntaxKind.MethodDeclaration:
Expand All @@ -796,7 +796,7 @@ module ts {
namedDeclarations.push(functionDeclaration);
}

forEachChild(node, visit);
forEachChild(node, visitNode);
}
break;

Expand Down Expand Up @@ -824,12 +824,12 @@ module ts {
case SyntaxKind.ObjectBindingPattern:
case SyntaxKind.ArrayBindingPattern:
case SyntaxKind.ModuleBlock:
forEachChild(node, visit);
forEachChild(node, visitNode);
break;

case SyntaxKind.Block:
if (isFunctionBlock(node)) {
forEachChild(node, visit);
forEachChild(node, visitNode);
}
break;

Expand All @@ -842,7 +842,7 @@ module ts {
case SyntaxKind.VariableDeclaration:
case SyntaxKind.BindingElement:
if (isBindingPattern((<VariableDeclaration>node).name)) {
forEachChild((<VariableDeclaration>node).name, visit);
forEachChild((<VariableDeclaration>node).name, visitNode);
break;
}
case SyntaxKind.EnumMember:
Expand All @@ -855,7 +855,7 @@ module ts {
// Handle named exports case e.g.:
// export {a, b as B} from "mod";
if ((<ExportDeclaration>node).exportClause) {
forEach((<ExportDeclaration>node).exportClause.elements, visit);
forEach((<ExportDeclaration>node).exportClause.elements, visitNode);
}
break;

Expand All @@ -876,7 +876,7 @@ module ts {
namedDeclarations.push(<NamespaceImport>importClause.namedBindings);
}
else {
forEach((<NamedImports>importClause.namedBindings).elements, visit);
forEach((<NamedImports>importClause.namedBindings).elements, visitNode);
}
}
}
Expand Down