Skip to content

#23180 - Generating source maps with relative path in sourceRoot option produces maps with absolute file paths#23989

Merged
mhegazy merged 4 commits into
microsoft:masterfrom
a-tarasyuk:bug/23180-generate-source-maps-with-relative-path
Jun 12, 2018
Merged

#23180 - Generating source maps with relative path in sourceRoot option produces maps with absolute file paths#23989
mhegazy merged 4 commits into
microsoft:masterfrom
a-tarasyuk:bug/23180-generate-source-maps-with-relative-path

Conversation

@a-tarasyuk
Copy link
Copy Markdown
Contributor

Fixes #23180

…urceRoot option produces maps with absolute file paths
@a-tarasyuk a-tarasyuk force-pushed the bug/23180-generate-source-maps-with-relative-path branch from 31a21ec to fe0e809 Compare May 9, 2018 10:01
… bug/23180-generate-source-maps-with-relative-path
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 21, 2018

thanks @a-tarasyuk, i would like to wait on merging this PR until i have forked 2.9.1, just since this is a breaking change.

@a-tarasyuk
Copy link
Copy Markdown
Contributor Author

@mhegazy ok, thanks

@mhegazy mhegazy added the Breaking Change Would introduce errors in existing code label Jun 12, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jun 12, 2018
@mhegazy mhegazy merged commit 7a322d7 into microsoft:master Jun 12, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Breaking Change Would introduce errors in existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants