Make getTextOfIdentifierOrLiteral only accept Identifier | StringLiteralLike | NumericLiteral#22002
Merged
2 commits merged intoFeb 21, 2018
Merged
Make getTextOfIdentifierOrLiteral only accept Identifier | StringLiteralLike | NumericLiteral#220022 commits merged into
2 commits merged into
Conversation
ghost
force-pushed
the
getTextOfIdentifierOrLiteral
branch
from
9d30514 to
b29e012
Compare
…eral only accept Identifier | StringLiteralLike | NumericLiteral
ghost
force-pushed
the
getTextOfIdentifierOrLiteral
branch
from
b29e012 to
05892a5
Compare
weswigham
requested changes
Feb 17, 2018
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
This is stealth mode also enabling string literal completions within no substitution template literals, no? That should probably be tested so we know if we break it. Otherwise, seems fine.
Author
|
In |
weswigham
approved these changes
Feb 21, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like with #21981, tightening this function required reexamining some casts elsewhere.