typingsInstaller:Remove triple-slash references#21982
Merged
Merged
Conversation
Replace them with an explicit list of files in tsconfig. I got this list by adding --listFiles to the jake-generated command.
ghost
approved these changes
Feb 16, 2018
mhegazy
reviewed
Feb 16, 2018
| @@ -1,4 +1,3 @@ | |||
| /// <reference path="typingsInstaller.ts"/> | |||
| /// <reference types="node" /> | |||
Contributor
There was a problem hiding this comment.
you do not need this one either. the tsconfig.json already has types: [ "node" ]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace them with an explicit list of files in tsconfig. I got this list by adding --listFiles to the jake-generated command.
I did this because I mistakenly added a depedency from compiler/utilities.ts to compiler/factory.ts and couldn't figure out how dependencies were resolved because I forgot about triple-slash references.