getTextOfPropertyName: Assert input value is a PropertyName#21981
Merged
1 commit merged intoFeb 16, 2018
Merged
Conversation
ghost
force-pushed
the
getTextOfPropertyName
branch
from
57bc1a2 to
a3c7fd1
Compare
weswigham
approved these changes
Feb 16, 2018
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
I like the assertion addition and the removal of casts. Just the comment below, NBD if one can't be found, though.
| if (parent.initializer && property) { | ||
| checkPropertyAccessibility(parent, parent.initializer, parentType, property); | ||
| const name = node.propertyName || node.name; | ||
| if (!isBindingPattern(name)) { |
Member
There was a problem hiding this comment.
Is there a documented bug this change fixes? If not, can you come up with a test case which would have crashed/error'd/behaved differently before? It'd be nice to just the coverage if possible.
Author
There was a problem hiding this comment.
Previously getTextOfPropertyName would have just returned undefined, then so would getPropertyOfType and it would be ignored. So there's no observable difference in behavior.
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...which detects an invalid cast.