Conversation
Member
|
To handle a conditional extension of null, shouldn't the regular case emit be updated to |
mhegazy
approved these changes
Oct 10, 2017
Contributor
Author
|
@weswigham If you conditionally extend null you can't define a constructor since you can't be certain whether you need to call |
Member
|
Actually, we just already do the right thing: class Bar {
constructor() {
console.log("made");
}
}
class Foo extends (Math.random() > 0.5 ? null : Bar) {
x = 2
}becomes var Bar = /** @class */ (function () {
function Bar() {
console.log("made");
}
return Bar;
}());
var Foo = /** @class */ (function (_super) {
__extends(Foo, _super);
function Foo() {
var _this = _super !== null && _super.apply(this, arguments) || this;
_this.x = 2;
return _this;
}
return Foo;
}((Math.random() > 0.5 ? null : Bar)));Already covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15395