Fix scope of @typedef references#16718
Merged
2 commits merged intoJun 28, 2017
Merged
Conversation
ghost
force-pushed
the
findAllRefs_typedef
branch
from
8389d53 to
4d22781
Compare
ghost
force-pushed
the
findAllRefs_typedef
branch
from
4d22781 to
b748d19
Compare
sandersn
reviewed
Jun 28, 2017
| ////function f2(obj) { return 0; } | ||
|
|
||
| const [r0, r1, r2] = test.ranges(); | ||
| verify.singleReferenceGroup("type T = number"); |
Member
There was a problem hiding this comment.
I haven't used singleReferenceGroup; does it interact with the result of test.ranges somehow? I expected to see r0, r1, r2 passed in to it somehow.
Author
There was a problem hiding this comment.
By default it uses all ranges. The line above it is useless though.
sandersn
approved these changes
Jun 28, 2017
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a
@typedefcomment was attached to a function, we considered that function to be its container. Now we make sure to go to the function's parent before looking for a container.