[Master] Language Service on Dynamic import#16406
Merged
Merged
Conversation
yuit
changed the title
yuit
changed the title
mhegazy
reviewed
Jun 9, 2017
| return undefined; | ||
|
|
||
| case SyntaxKind.StringLiteral: | ||
| // import x = require("./mo/*gotToDefinitionHere*/d") |
Contributor
There was a problem hiding this comment.
can we unify all these conditions.
Contributor
Author
There was a problem hiding this comment.
We can but I split them so that it is a bit easier to read.... I guess i can put them in one condition and make comment
mhegazy
approved these changes
Jun 12, 2017
Contributor
mhegazy
left a comment
mhegazy
left a comment
There was a problem hiding this comment.
with simplification of the condition in getSymbolAtLocation
Contributor
|
Please port this to release-2.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16402 ...