Port checkJs fix from master#16227
Merged
Merged
Conversation
Report unreachable code in JS files when --checkjs is passed, but not otherwise.
|
@amcasey, |
Member
Author
|
billti
approved these changes
Jun 2, 2017
amcasey
commented
Jun 2, 2017
| /** The version of the TypeScript compiler release */ | ||
| export const version = "2.3.4"; | ||
| export const version = "2.3.5"; | ||
| } |
Member
Author
There was a problem hiding this comment.
Does the line ending matter? I'm not sure how it changed, but I can revert it.
Member
Author
|
Confirmed that the failure is due to the absence of an npm 5 workaround merged into master but not release-2.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was #16210.