Fix duplication of first comment in file#15172
Closed
mishoo wants to merge 1 commit into
Closed
Conversation
I'm not sure this is the "proper" fix, but it does resolve the issue. `iterateCommentRanges` is called with pos=0 and trailing=true, making the first comment show up twice (as it will be iterated as a leading comment too). Fixes microsoft#12979
|
@mishoo, It will cover your contributions to all Microsoft-managed open source projects. |
|
@mishoo, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Can you please consider this PR for merging? It's a small nuisance, but can turn into a real headache when JSDoc comments get duplicated. See #12979 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the "proper" fix, but it does resolve the issue.
iterateCommentRangesis called with pos=0 and trailing=true, making the first comment show up twice (as it will be iterated as a leading comment too).Fixes #12979