Fix duplicate identifier reporting in classes - #13796
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits intoFeb 14, 2017
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits into
Nathan Shively-Sanders (sandersn) merged 2 commits into
Conversation
Previously declarations in the order method-property would not report an
error, but the order property-method would. Now both orders report
"Duplicate identifier '{0}'."
Member
Author
|
Ryan Cavanaugh (@RyanCavanaugh) mind taking a look since you wrote |
Mohamed Hegazy (mhegazy)
approved these changes
Feb 14, 2017
Nathan Shively-Sanders (sandersn)
deleted the
fix-duplicate-identifier-reporting
branch
February 14, 2017 19:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13141 by updating the code from #8696 to understand MethodDeclaration as well.