Skip to content

Object rest emit for method and accessor parameters#12272

Merged
rbuckton merged 2 commits into
masterfrom
object-rest-emit-for-method-and-accessor-parameters
Nov 16, 2016
Merged

Object rest emit for method and accessor parameters#12272
rbuckton merged 2 commits into
masterfrom
object-rest-emit-for-method-and-accessor-parameters

Conversation

@sandersn
Copy link
Copy Markdown
Member

I missed these before, so emit was incorrect for object rest in a method or accessor parameter. Thanks @rbuckton for noticing it.

I missed these before, so emit was incorrect for object rest in a method
or accessor parameter.
@rbuckton
Copy link
Copy Markdown
Contributor

@sandersn I have also addressed this in #12250, though I need to add your test cases.

@sandersn
Copy link
Copy Markdown
Member Author

Yeah, let's take your PR and you can just grab the tests from this one.

@rbuckton
Copy link
Copy Markdown
Contributor

I've merged the tests into #12250.

@rbuckton rbuckton merged commit 498d978 into master Nov 16, 2016
@sandersn sandersn deleted the object-rest-emit-for-method-and-accessor-parameters branch January 4, 2017 22:48
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants