Skip to content

Removed lambdas in replace of inline function callbacks #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattmazzola merged 1 commit into from
Aug 30, 2016
Merged

Removed lambdas in replace of inline function callbacks #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/app/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ $(function () {
}
else {
return response.json()
.then(error => {
.then(function (error) {
throw new Error(error);
});
}
Expand Down
14 changes: 7 additions & 7 deletions demo/app/filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,19 +211,19 @@ $(function () {
function updateFiltersPane() {
const $filters = $('.filters');

$.each($filters, (index, element) => {
$.each($filters, function (index, element) {
const $element = $(element);
const filterable = $element.data('filterable');

console.log($element, filterable);

filterable.getFilters()
.then(filters => {
.then(function (filters) {
console.log(filterable.displayName, filters);
$element.empty();
filters
.map(generateFilterElement)
.forEach($filter => {
.forEach(function ($filterS) {
$element.append($filter);
});
});
Expand Down Expand Up @@ -299,12 +299,12 @@ $(function () {

// Setup page filters containers which have filterable
report.getPages()
.then(pages => {
.then(function (pages) {
reportPages = pages;

pages
.map(generatePageFiltersContainer)
.forEach($pageFiltersContainer => {
.forEach(function ($pageFiltersContainer) {
$pageFilters.append($pageFiltersContainer)
});
});
Expand All @@ -326,7 +326,7 @@ $(function () {
console.log('remove filter', $element, $filtersContainer, filterToRemove, filterable);

filterable.getFilters()
.then(filters => {
.then(function (filters) {
let index = -1;
filters.some(function (filter, i) {
if (JSON.stringify(filter) === JSON.stringify(filterToRemove)) {
Expand Down Expand Up @@ -398,7 +398,7 @@ $(function () {
}
else {
return response.json()
.then(error => {
.then(function (error) {
throw new Error(error);
});
}
Expand Down
2 changes: 1 addition & 1 deletion demo/app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ $(function () {
}
else {
return response.json()
.then(error => {
.then(function (error) {
throw new Error(error);
});
}
Expand Down
2 changes: 1 addition & 1 deletion demo/app/pagenavigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ $(function () {
}
else {
return response.json()
.then(error => {
.then(function (error) {
throw new Error(error);
});
}
Expand Down
2 changes: 1 addition & 1 deletion demo/app/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ $(function () {
}
else {
return response.json()
.then(error => {
.then(function (error) {
throw new Error(error);
});
}
Expand Down