Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ var ghPages = require('gulp-gh-pages'),
webpackTestConfig = require('./webpack.test.config'),
runSequence = require('run-sequence'),
argv = require('yargs').argv;
;
;

var package = require('./package.json');
var webpackBanner = package.name + " v" + package.version + " | (c) 2016 Microsoft Corporation " + package.license;
Expand Down
2 changes: 1 addition & 1 deletion src/embed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export interface IEmbedConfiguration {
accessToken?: string;
settings?: models.ISettings;
pageName?: string;
filters?: (models.IBasicFilter | models.IAdvancedFilter)[];
filters?: models.IFilter[];
}

export interface IInternalEmbedConfiguration extends models.ILoadConfiguration {
Expand Down
8 changes: 4 additions & 4 deletions src/ifilterable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ export interface IFilterable {
/**
* Gets the filters currently applied to the object.
*
* @returns {(Promise<(models.IBasicFilter | models.IAdvancedFilter)[]>)}
* @returns {(Promise<models.IFilter[]>)}
*/
getFilters(): Promise<(models.IBasicFilter | models.IAdvancedFilter)[]>;
getFilters(): Promise<models.IFilter[]>;
/**
* Replaces all filters on the current object with the specified filter values.
*
* @param {((models.IBasicFilter | models.IAdvancedFilter)[])} filters
* @param {(models.IFilter[])} filters
* @returns {Promise<void>}
*/
setFilters(filters: (models.IBasicFilter | models.IAdvancedFilter)[]): Promise<void>;
setFilters(filters: models.IFilter[]): Promise<void>;
/**
* Removes all filters from the current object.
*
Expand Down
8 changes: 4 additions & 4 deletions src/page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ export class Page implements IPageNode, IFilterable {
* .then(pages => { ... });
* ```
*
* @returns {(Promise<(models.IBasicFilter | models.IAdvancedFilter)[]>)}
* @returns {(Promise<models.IFilter[]>)}
*/
getFilters(): Promise<(models.IBasicFilter | models.IAdvancedFilter)[]> {
getFilters(): Promise<models.IFilter[]> {
return this.report.service.hpm.get<models.IFilter[]>(`/report/pages/${this.name}/filters`, { uid: this.report.config.uniqueId }, this.report.iframe.contentWindow)
.then(response => response.body,
response => {
Expand Down Expand Up @@ -138,10 +138,10 @@ export class Page implements IPageNode, IFilterable {
* .catch(errors => { ... });
* ```
*
* @param {((models.IBasicFilter | models.IAdvancedFilter)[])} filters
* @param {(models.IFilter[])} filters
* @returns {Promise<void>}
*/
setFilters(filters: (models.IBasicFilter | models.IAdvancedFilter)[]): Promise<void> {
setFilters(filters: models.IFilter[]): Promise<void> {
return this.report.service.hpm.put<models.IError[]>(`/report/pages/${this.name}/filters`, filters, { uid: this.report.config.uniqueId }, this.report.iframe.contentWindow)
.catch(response => {
throw response.body;
Expand Down
4 changes: 2 additions & 2 deletions src/report.ts
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,10 @@ export class Report extends embed.Embed implements IReportNode, IFilterable {
* });
* ```
*
* @param {((models.IBasicFilter | models.IAdvancedFilter)[])} filters
* @param {(models.IFilter[])} filters
* @returns {Promise<void>}
*/
setFilters(filters: (models.IBasicFilter | models.IAdvancedFilter)[]): Promise<void> {
setFilters(filters: models.IFilter[]): Promise<void> {
return this.service.hpm.put<models.IError[]>(`/report/filters`, filters, { uid: this.config.uniqueId }, this.iframe.contentWindow)
.catch(response => {
throw response.body;
Expand Down
8 changes: 4 additions & 4 deletions src/visual.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ export class Visual implements IVisualNode, IFilterable {
* .then(pages => { ... });
* ```
*
* @returns {(Promise<(models.IBasicFilter | models.IAdvancedFilter)[]>)}
* @returns {(Promise<models.IFilter[]>)}
*/
getFilters(): Promise<(models.IBasicFilter | models.IAdvancedFilter)[]> {
getFilters(): Promise<models.IFilter[]> {
return this.page.report.service.hpm.get<models.IFilter[]>(`/report/pages/${this.page.name}/visuals/${this.name}/filters`, { uid: this.page.report.config.uniqueId }, this.page.report.iframe.contentWindow)
.then(response => response.body,
response => {
Expand Down Expand Up @@ -79,10 +79,10 @@ export class Visual implements IVisualNode, IFilterable {
* .catch(errors => { ... });
* ```
*
* @param {((models.IBasicFilter | models.IAdvancedFilter)[])} filters
* @param {(models.IFilter[])} filters
* @returns {Promise<void>}
*/
setFilters(filters: (models.IBasicFilter | models.IAdvancedFilter)[]): Promise<void> {
setFilters(filters: models.IFilter[]): Promise<void> {
return this.page.report.service.hpm.put<models.IError[]>(`/report/pages/${this.page.name}/visuals/${this.name}/filters`, filters, { uid: this.page.report.config.uniqueId }, this.page.report.iframe.contentWindow)
.catch(response => {
throw response.body;
Expand Down
2 changes: 1 addition & 1 deletion test/utility/mockApp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface IApp {
validateVisual(visual: models.IVisual): Promise<models.IError[]>;
// Filters
getFilters(): Promise<models.IFilter[]>;
setFilters(filters: (models.IBasicFilter | models.IAdvancedFilter)[]): Promise<void>;
setFilters(filters: models.IFilter[]): Promise<void>;
validateFilter(filter: models.IFilter): Promise<models.IError[]>;
// Other
print(): Promise<void>;
Expand Down