Changed (IBasicFilter | IAdvancedFilter) to IFilter#39
Conversation
| gulp.task("docs", 'Compile documentation from src code', function () { | ||
| return gulp | ||
| .src(["src/**/*.ts"]) | ||
| .src(["typings/globals/es6-promise/index.d.ts", "src/**/*.ts"]) |
There was a problem hiding this comment.
This allows the typedoc to generate docs with Promise
There was a problem hiding this comment.
This is unrelated to changing filter types / interfaces though.
Would rather fix typedoc in separate PR with all of the needed .d.ts files.
I assume it needs all the dependent libraries, perhaps just include all typings folder.
There was a problem hiding this comment.
Big reason for updating to IFilter was to support typedoc. Typedoc doesn't support the (A|B) syntax. If we include all the typings then it will generate docs for dev dependencies like jasmine, etc.
There was a problem hiding this comment.
It sounds like there are two different issues here.
- Typedoc doesn't support union types
- External .d.ts files need to be included
(es6-promise, wpmp, hpm, router, models)
If true, the second issue is independent. Or is 2 a non-issue and typedoc already handles this?
3 participants
No description provided.