Repository navigation
Use token-based authentication instead of the access key in the AzureFileShareService - #779
Merged
Sergiy Matusevych (motus) merged 24 commits intoJul 24, 2024
Conversation
Contributor
|
Part of why we went with the Use of |
Contributor
|
As long as we're removing account storage key, does removing fileshare also make sense? We could use blobs instead I guess. Maybe less nice though and too many changes. |
Brian Kroth (bpkroth)
changed the title
Brian Kroth (bpkroth)
approved these changes
Jul 23, 2024
Brian Kroth (bpkroth)
left a comment
Brian Kroth (bpkroth)
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks good. Only feedback was to move the SupportsAuth check to __init__ so we can check for proper configs at startup time rather than at file transfer need time which might be after some experiment trial has already run.
Sergiy Matusevych (motus)
enabled auto-merge (squash)
July 23, 2024 22:23
Sergiy Matusevych (motus)
disabled auto-merge
July 23, 2024 22:29
Sergiy Matusevych (motus)
force-pushed
the
sergiym/svc/fs_token_auth
branch
from
July 23, 2024 23:58
35e77b4 to
827492f
Compare
…vide a proper implementation later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
AzureFileShareServiceclass use token-based credential instead of the access key. This PR is part of #777NOTE:
_share_clientto avoid issues with JSON schema validation tests.azcopyon the remote VMs instead of mounting the file share using the access key"storageAccountKey"from configurations and tests and document the new mechanism