Skip to content

ports/esp32/esp32_rmt.c: #7015 ISR-driven pulse generator in RMT#9685

Open
Andrei-Pozolotin wants to merge 1 commit into
micropython:masterfrom
random-builder:rmt_7015
Open

ports/esp32/esp32_rmt.c: #7015 ISR-driven pulse generator in RMT#9685
Andrei-Pozolotin wants to merge 1 commit into
micropython:masterfrom
random-builder:rmt_7015

Conversation

@Andrei-Pozolotin
Copy link
Copy Markdown

@Andrei-Pozolotin Andrei-Pozolotin commented Oct 20, 2022 •
edited
Loading

See: #7015

Design Motivation:

  1. store static pulse pattern inside RMT driver only once, as a "pulse vocabulary" of available stanzas
  2. keep playing "pulse words" from this RMT pulse store with different stanza size and frequency via ISR call back

Purpose: provide high performance ISR-driven pulse generator in RMT.

This adds 2 new functions to ports/esp32/esp32_rmt.c:

// RMT.store_pulses(self, item_list:list[int]) -> None
// RMT.issue_pulses(self, tx_ready_func:callable, item_index:int, item_count:int, clock_div:int) -> None

Use case and examples are discussed here:
#7015 (comment)
#7015 (comment)

@Andrei-Pozolotin
ports/esp32/esp32_rmt.c: ISR-driven pulse generator in RMT.
207e296 
See micropython#7015. This adds 2 new functions to ports/esp32/esp32_rmt.c:
// RMT.store_pulses(self, item_list:list[int]) -> None
// RMT.issue_pulses(self, tx_ready_func:callable, item_index:int,
item_count:int, clock_div:int) -> None
@Andrei-Pozolotin
Copy link
Copy Markdown
Author

Andrei-Pozolotin commented Oct 20, 2022

@peterhinch : please review

@peterhinch
Copy link
Copy Markdown
Contributor

peterhinch commented Oct 21, 2022

As per my original suggestions in #7015, it would offer potential RAM savings if RMT.store_pulses(self, item_list:list[int]) could accept any object supporting the buffer protocol.

@peterhinch : please review

The general principle looks good, but I'm not the best qualified to review the C code. Hopefully someone with a deeper knowledge of the MP API will turn up.

@Andrei-Pozolotin
Copy link
Copy Markdown
Author

Andrei-Pozolotin commented Oct 22, 2022

@peterhinch : thank you

@Andrei-Pozolotin
Copy link
Copy Markdown
Author

Andrei-Pozolotin commented Oct 22, 2022

@jonathanhogg : please review

@jonathanhogg
Copy link
Copy Markdown
Contributor

jonathanhogg commented Oct 24, 2022

@jonathanhogg : please review

Comments coming in the #7015 issue, as that seems the most useful place for discussion…

@Andrei-Pozolotin
Copy link
Copy Markdown
Author

Andrei-Pozolotin commented Oct 25, 2022

@jonathanhogg : thank you

@Andrei-Pozolotin
Copy link
Copy Markdown
Author

Andrei-Pozolotin commented Oct 25, 2022

@mattytrentini : please review

@Andrei-Pozolotin Andrei-Pozolotin mentioned this pull request Oct 25, 2022
Open
@Andrei-Pozolotin
Copy link
Copy Markdown
Author

Andrei-Pozolotin commented Nov 2, 2022

@robert-hh : please review

@Gadgetoid Gadgetoid mentioned this pull request Feb 29, 2024
Merged
@projectgus
Copy link
Copy Markdown
Contributor

projectgus commented Mar 7, 2024

This is an automated heads-up that we've just merged a Pull Request
that removes the STATIC macro from MicroPython's C API.

See #13763

A search suggests this PR might apply the STATIC macro to some C code. If it
does, then next time you rebase the PR (or merge from master) then you should
please replace all the STATIC keywords with static.

Although this is an automated message, feel free to @-reply to me directly if
you have any questions about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

port-esp32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Andrei-Pozolotin @peterhinch @jonathanhogg @projectgus @dpgeorge