tools/normalise_mpconfigport.py: Add script to normalise config (WIP)#7538
Closed
dpgeorge wants to merge 1 commit into
Closed
tools/normalise_mpconfigport.py: Add script to normalise config (WIP)#7538dpgeorge wants to merge 1 commit into
dpgeorge wants to merge 1 commit into
Conversation
Contributor
|
This script does run on Debian 10, since the default Python version is 3.7. Python 3.7 does not support assignment expressions. Less elegant replacement: |
Codecov Report
@@ Coverage Diff @@
## master #7538 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 154 154
Lines 19988 19988
=======================================
Hits 19646 19646
Misses 342 342
Continue to review full report at Codecov.
|
Signed-off-by: Damien George <[email protected]>
df8dd48 to
048bc42
Compare
Member
Author
|
I really like the walrus operator! Anyway, updated to not use it. |
Contributor
|
Thanks. Agreed that it looks much better with the walrus operator. But the new code variant looks good. Very clear. |
Member
Author
|
This is not really needed now that we have ROM feature levels. |
RetiredWizard
pushed a commit
to RetiredWizard/micropython
that referenced
this pull request
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.