See #4874 for where this was added, in particular the discussion there about trying to fit this on one line. I guess it's not possible to do that?

I spoke to @nevercast and apparently there were issues in their build using patsubst (although it works fine for me).

ESPIDF_DRIVER_O = $(patsubst %.c,%.o,$(wildcard $(ESPCOMP)/driver/*.c))

He's going to get back to me with more details.

I was sick last week and didn't get around to checking on this, I'll get to it this week. Sorry about the delay.

I've updated to use patsubst, as far as I understand this is exactly what patsubst is for, and I can verify that it correctly generates the set of .o files corresponding to $(ESPCOMP)/driver/*.c.

I've spoken with @jimmo in Slack and while I haven't found the time to test this personally, I'm happy for the change. I have a build server at work that will test this commit against my own codebase as soon as it lands in #master so I'm not too worried.

I checked locally and it builds fine, builds the same way as before this patch. Also Travis is green.

Merged in 331c224

Jenkins passed at my end too 🎉

Great!

See #4935 for a follow up.