tests: remove working cpydiff for float rounding#17802
Merged
dpgeorge merged 2 commits intoAug 1, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17802 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22276 22276
=======================================
Hits 21917 21917
Misses 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
The unix port is needed to build the docs, due to the cpydiff tests which
run both CPython and MicroPython (unix port). That was previously not
failing the CI because the output from MicroPython was:
/bin/sh: 1: ../ports/unix/build-standard/micropython: not found
which doesn't match the CPython output for any of the cpydiff tests, and so
it was considered a "pass" in terms of the output differing.
Also, run the docs workflow when py/ or tests/cpydiff/ changes, because the
cpydiff results may change when the core code changes.
Signed-off-by: Damien George <[email protected]>
dpgeorge
force-pushed
the
tests-remove-working-cpydiff-float-rounding
branch
from
6b0f6f4 to
30430a6
Compare
Member
Author
|
OK, docs build now fails CI properly with: |
Since commit dbbaa95, this test now produces the same output on MicroPython as CPython does, namely -1e+01. Signed-off-by: Damien George <[email protected]>
dpgeorge
force-pushed
the
tests-remove-working-cpydiff-float-rounding
branch
from
30430a6 to
947d544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #17444 float formatting was improved, which made
tests/cpydiff/types_float_rounding.pynow behave the same in MicroPython as in CPython.But the CI did not pick this up. So tweak the workflow and delete that cpydiff test.
Testing
To be tested by CI.