stm32/fdcan: Fix extended CAN ID filtering for stm32g4.#16546
Merged
dpgeorge merged 1 commit intoJan 17, 2025
Conversation
|
Code size report: |
dpgeorge
approved these changes
Jan 14, 2025
The memory bank addresses used for these are independent, can (and must) enable both. Also looks like no need to shrink these if FDCAN2 is added, the Reference Manual is a bit unclear but looks like the peripheral's RAM multiplies out for each additional controller. Signed-off-by: Angus Gratton <[email protected]>
dpgeorge
force-pushed
the
bugfix/stm32g4_can_ext_filter
branch
from
90eaf96 to
21b7bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fix was split out from #15989.
Without this fix, extended CAN ID filtering doesn't work on STM32G4. The memory bank addresses used for these are independent, can (and must) enable both.
Also looks like no need to halve these if FDCAN2 is added (as per comment). The Reference Manual is a bit unclear but looks like the peripheral's RAM multiplies out for each additional controller.
Testing