qemu-arm/qemu-riscv: consolidate Makefile.test into main Makefile#15577
Closed
dpgeorge wants to merge 2 commits into
Closed
qemu-arm/qemu-riscv: consolidate Makefile.test into main Makefile#15577dpgeorge wants to merge 2 commits into
dpgeorge wants to merge 2 commits into
Conversation
Signed-off-by: Damien George <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15577 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 161 161
Lines 21281 21281
=======================================
Hits 20948 20948
Misses 333 333 ☔ View full report in Codecov by Sentry. |
|
Code size report: |
Signed-off-by: Damien George <[email protected]>
dpgeorge
force-pushed
the
ports-qemu-simplify-makefile
branch
from
248101b to
d2de1bb
Compare
Contributor
|
Out of curiosity, wouldn't the |
Member
Author
The |
Member
Author
|
Closing in favour of #15624. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the
qemu-armandqemu-riscvports have separateMakefile.testfiles needed to build and run the tests. It's a bit awkward (and unconventional within this project) to have to runmake -f Makefile.test testto run the tests.The files don't really need to be separate, and this PR consolidates
Makefile.testinto the mainMakefile.Now the tests are run simply with
make test.Testing
Locally ran
make testand it had the same output as before doingmake -f Makefile.test test.CI is also updated to work with this new, simplified make target.
Trade-offs and Alternatives
The alternative is to leave it as-is, but I think this change makes it simpler, easier to understand, and more like other ports (which only have one Makefile).