nrf/Makefile: Fix GCC_VERION regex.#15553
Merged
Merged
Conversation
agatti
reviewed
Jul 29, 2024
Contributor
agatti
left a comment
agatti
left a comment
There was a problem hiding this comment.
Instead of using a regex and invoking sed, how about something like $(shell $(CC) -dumpversion)? It's been available in GCC since pretty much forever as far as I know.
Contributor
Author
Oh that's an easy yes! Thanks, not sure why I couldn't find that when I searched initially. Stack overflow let me down ;-) Cheers, I'll update this shortly as such. |
andrewleech
force-pushed
the
nrf_arm_version
branch
from
4d2b368 to
759fd2a
Compare
Previously it was truncating the first digit of the version if the major number had more than one digit. Signed-off-by: Andrew Leech <[email protected]>
dpgeorge
force-pushed
the
nrf_arm_version
branch
from
759fd2a to
70a7e0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #15158 (comment)