Fix invalid clock config for ethernet chip on STM32 F-series MCU#13422
Fix invalid clock config for ethernet chip on STM32 F-series MCU#13422ukicomputers wants to merge 10 commits into
Conversation
Tested on STM32F437ZG with LAN8720A. Valid for F7, tested on F4 series, usable on others. Check discussion micropython#13406 for more info about problem. May required fixing this problem on H-series! (check updated lines) Signed-off-by: Uglješa Lukešević <[email protected]>
…d add required speed for communication pins. Signed-off-by: Uglješa Lukešević <[email protected]>
|
Some comments:
|
|
@robert-hh I will change the pin configuration. For the MCO clock, should I add a flag if someone wants to use it like: |
|
Better put it into a board_init.c file, because it is not strictly related to LAN. But if it is in eth.c,. call the different, like |
Signed-off-by: Uglješa Lukešević <[email protected]>
Add default flag for outputting clock value. Signed-off-by: Uglješa Lukešević <[email protected]>
Signed-off-by: Uglješa Lukešević <[email protected]>
|
Got it. I think better to put it as
Don't yet merge this PR because it still needs to be tested. |
|
You can set a PR top draft mode. Then it will not be merged. Anyhow, merging takes a while. |
|
Sorry, what do you mean? I added it with |
|
Now I see it. At the time of writing, it was not visible yet. |
Signed-off-by: Uglješa Lukešević <[email protected]>
Signed-off-by: Uglješa Lukešević <[email protected]>
Conclusion for this PR
|
|
Signed-off-by: Uglješa Lukešević <[email protected]>
|
Now that #13630 has been merged, I'm not sure how much of this PR is needed. If parts of this PR are needed then please rebase on the latest master. |
|
After @robert-hh commited, most of the issues are resolved. Only specific hardware design like mine requires setting clock output. If someone needs CLK_OUT set up, it should be defined in |
|
Also, if someone needs it defined in MPY |
Tested on STM32F437ZG with LAN8720A. Valid for F7, tested on F4 series, usable on others. Check discussion #13406 for more info about problem. May required fixing this problem on H-series! (check updated lines)