mimxrt/modmachine.c: Fix settings for the MIMXRT1170 board.#12877
Merged
Conversation
Member
|
Thanks for this @robert-hh ! The build-all-the-boards script caught this overnight, thanks for the fix. See also #12878 |
Contributor
Author
These were not changed with commit c0b64a3 for using tools/boardgen.py. Signed-off-by: robert-hh <[email protected]>
This option was removed in PR micropython#12211. Signed-off-by: robert-hh <[email protected]>
dpgeorge
force-pushed
the
mimxrt_pin_1170
branch
from
e188ddb to
e63d718
Compare
Member
|
Thanks for updating the documentation @robert-hh ! |
Contributor
Author
|
Looking into the changed code it would have been complicated (or ugly) to restore the integer variant for naming a Pin. So I went for changing the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were not changed with commit c0b64a3 for using tools/boardgen.py.