extmod/uasyncio: Fix syntax of generator functions#10190
Merged
Conversation
damz
force-pushed
the
pr/uasyncio-generator
branch
from
1c0ca83 to
a05d80c
Compare
|
Code size report: |
1 similar comment
|
Code size report: |
dpgeorge
reviewed
Dec 13, 2022
Member
|
Thanks for this, I agree with the change. It's actually close to what I did in #6668, which adds support for async generators. |
damz
force-pushed
the
pr/uasyncio-generator
branch
from
a05d80c to
74c5668
Compare
Contributor
Author
|
@dpgeorge Thanks for the review. I updated the PR as requested. |
|
Code size report: |
damz
force-pushed
the
pr/uasyncio-generator
branch
from
74c5668 to
c8c8399
Compare
|
Code size report: |
The compiler is not picky right now, but these are actually all syntax errors: - await is only valid in an async function - async functions that use yield are actually async generators (a construct not supported by the compiler right now)
dpgeorge
force-pushed
the
pr/uasyncio-generator
branch
from
c8c8399 to
0eba00a
Compare
|
Code size report: |
Member
|
Thanks for updating. Rebased and merged. |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Mar 31, 2025
Add guards to common_hal_pulseio_pulse(in|out)_deinit to prevent doub…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix the syntax of generator functions in the
uasynciopackage:awaitis only valid in anasyncfunctionasyncfunctions that useyieldare actually async generators (a construct not supported by the compiler right now)Why?
The compiler is not picky right now, but these are actually all syntax errors.