Codecov Report

Merging #10031 (1bd5038) into master (ac5934c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10031   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         156      156           
  Lines       20520    20520           
=======================================
  Hits        20179    20179           
  Misses        341      341           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I can see how this is a useful addition. But my reservations with it are:

• it's not CPython compatible (CPython has no os.ioctl, although subtly what's added here is uos.ioctl)
• it doesn't match how other functionality like close, flush exist as methods on the stream object (not functions in uos)
• adding constants is expensive in terms of code size and all ports would need to include them for them to be useful (otherwise if you can't rely on them being there on all ports you must use integers for portable code)

You can also see that mp_stream_ioctl_obj() already exists and provides this ioctl functionality (it's just not wired up to many classes).

The main use case here (as far as I see it, at least in the immediate case at hand) is for unit testing. So to move forward I'd suggest just adding mp_stream_ioctl_obj() to the locals dict tables of file/stream objects that need it for testing #9871, and guard it by #if MICROPY_UNIX_COVERAGE.

Sounds very reasonable, closing this.