Repository navigation
zmqserver can cache objects - #75
Merged
Merged
Conversation
If the zmqserver gets a set_object command that sets precisely the same object data on precisely the same path that already exists, then do not forward it to the connected websockets. This makes a *dramatic* improvement in the workflow of using meshcat on colab (at least as we use it in drake), because we don't have to repeatedly download large meshfiles from repeated simulations.
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 75.98% 75.83% -0.15%
==========================================
Files 11 11
Lines 1012 1014 +2
==========================================
Hits 769 769
- Misses 243 245 +2
Continue to review full report at Codecov.
|
rdeits
approved these changes
Aug 30, 2020
RussTedrake
added a commit
to RussTedrake/drake
that referenced
this pull request
Aug 30, 2020
… server Adds an argument to the constructor to avoid deleting the entire tree on every run. Sets uuids deterministically based on the mesh file so that they can be recognized as identical on the server. See meshcat-dev/meshcat-python#75 This makes a *dramatic* improvement in the workflow of using meshcat on colab (at least as we use it in drake), because we don't have to repeatedly download large meshfiles from repeated simulations.
RussTedrake
added a commit
to RussTedrake/drake
that referenced
this pull request
Sep 1, 2020
… server Adds an argument to the constructor to avoid deleting the entire tree on every run. Sets uuids deterministically based on the mesh file so that they can be recognized as identical on the server. See meshcat-dev/meshcat-python#75 This makes a *dramatic* improvement in the workflow of using meshcat on colab (at least as we use it in drake), because we don't have to repeatedly download large meshfiles from repeated simulations.
EricCousineau-TRI
pushed a commit
to RobotLocomotion/drake
that referenced
this pull request
Sep 1, 2020
… server (#13971) Adds an argument to the constructor to avoid deleting the entire tree on every run. Sets uuids deterministically based on the mesh file so that they can be recognized as identical on the server. See meshcat-dev/meshcat-python#75 This makes a *dramatic* improvement in the workflow of using meshcat on colab (at least as we use it in drake), because we don't have to repeatedly download large meshfiles from repeated simulations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
zmqservergets aset_objectcommand that sets precisely the same object data on precisely the same path that already exists, then do not forward it to the connected websockets.This makes a dramatic improvement in the workflow of using meshcat on colab (at least as we use it in drake), because we don't have to repeatedly download large meshfiles from repeated simulations.