Features: set captured image resolution, set camera target, set camera position by ManifoldFR · Pull Request #109 · meshcat-dev/meshcat-python

ManifoldFR · 2022-01-11T16:00:26Z

This follows the PR meshcat-dev/meshcat#111. I expose the following new features from that PR:

setting the camera target
specifying the get_image() resolution

Also:

a convenience function for setting camera position (in right-handed coordinates)

rdeits · 2022-03-23T01:37:24Z

+
+class SetCamTarget:
+    __slots__ = ["value"]
+    def __init__(self, value):


value is pretty vague as a variable name. What are the expected contents, and what do they do?

It's supposed to be the camera's target position, in 3D. I made this more explicit the commit I pushed just now.

codecov-commenter · 2022-04-03T14:05:42Z

Codecov Report

Base: 73.39% // Head: 72.29% // Decreases project coverage by -1.10% ⚠️

Coverage data is based on head (41b5370) compared to base (cd04af4).
Patch coverage: 34.37% of modified lines in pull request are covered.

❗ Current head 41b5370 differs from pull request most recent head 6b2b9f2. Consider uploading reports for the commit 6b2b9f2 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   73.39%   72.29%   -1.10%     
==========================================
  Files          11       11              
  Lines        1075     1101      +26     
==========================================
+ Hits          789      796       +7     
- Misses        286      305      +19

Impacted Files	Coverage Δ
src/meshcat/geometry.py	`88.96% <ø> (ø)`
src/meshcat/servers/zmqserver.py	`28.89% <0.00%> (-0.34%)`	⬇️
src/meshcat/visualizer.py	`71.55% <35.71%> (-4.15%)`	⬇️
src/meshcat/commands.py	`80.59% <40.00%> (-11.86%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ManifoldFR · 2022-04-20T12:39:16Z

Just rebased on master.

ManifoldFR · 2022-07-03T14:56:26Z

Did a clean rebase on master and updated demo.ipynb with examples of the camera pos/target options

Codecov still doesn't seem to like the commit however, maybe it doesn't look at the Jupyter notebook?

ManifoldFR · 2022-11-16T09:35:39Z

Hi @rdeits, sorry to be a bother, but do you think this PR is ready to be merged?
We kind of let it marinate in open PR limbo (😅) but now with @jcarpent we're thinking about using the new features from this PR in a future release of Pinocchio

Should I work on the code coverage or is that OK?

Thanks !

* update meshcat submodule w/ new features * expose setting the camera target * expose get_image() resolution option

* takes argument in (x,y,z) format

* update docstring of set_cam_target * fix set_cam_pos behavior * update demo.ipynb with example on changing cam focus & position

rdeits · 2023-04-19T02:49:49Z

I'm embarrassed that it took me so long to get back to this, but I do really appreciate the contribution. I've verified that this works well locally, so let's do it!

rdeits reviewed Mar 23, 2022

View reviewed changes

ManifoldFR force-pushed the feat/set-capture-resolution branch from 4f540af to f704c1b Compare April 20, 2022 12:38

ManifoldFR force-pushed the feat/set-capture-resolution branch from f704c1b to e038e46 Compare June 14, 2022 14:31

ManifoldFR force-pushed the feat/set-capture-resolution branch 5 times, most recently from 9437d1f to 17d996f Compare July 3, 2022 14:10

ManifoldFR changed the title ~~Feature: set captured image resolution + set camera target~~ Feature: set captured image resolution, set camera target, set camera position Jul 3, 2022

ManifoldFR changed the title ~~Feature: set captured image resolution, set camera target, set camera position~~ Features: set captured image resolution, set camera target, set camera position Nov 16, 2022

ManifoldFR force-pushed the feat/set-capture-resolution branch from 1ec6a41 to b4550a0 Compare December 13, 2022 18:43

ManifoldFR added 2 commits January 24, 2023 19:01

Set captured image resolution & camera target

099916a

* update meshcat submodule w/ new features * expose setting the camera target * expose get_image() resolution option

visualizer: add set_cam_pos convenience method

bf37015

* takes argument in (x,y,z) format

ManifoldFR force-pushed the feat/set-capture-resolution branch 3 times, most recently from eab0fa6 to a15b340 Compare January 24, 2023 18:12

ManifoldFR added 2 commits January 24, 2023 19:14

visualizer: change set_cam_target to expect right-handed coord input

8affad0

* update docstring of set_cam_target * fix set_cam_pos behavior * update demo.ipynb with example on changing cam focus & position

geometry: fix warning about "_meshfile" being deprecated from js module

41b5370

ManifoldFR force-pushed the feat/set-capture-resolution branch from a15b340 to 41b5370 Compare January 24, 2023 18:14

Reset meshcat.js module version

6b2b9f2

ManifoldFR force-pushed the feat/set-capture-resolution branch from 03be33d to 6b2b9f2 Compare January 24, 2023 18:19

ManifoldFR mentioned this pull request Feb 4, 2023

[python/visualize] Extend visualizer features and implement them for MeshcatVisualizer stack-of-tasks/pinocchio#1845

Merged

9 tasks done

ManifoldFR mentioned this pull request Feb 24, 2023

Focusing point with camera #133

Open

rdeits merged commit 794a402 into meshcat-dev:master Apr 19, 2023

ManifoldFR deleted the feat/set-capture-resolution branch April 19, 2023 11:53

Navigation Menu

Repository navigation

Features: set captured image resolution, set camera target, set camera position - #109

Features: set captured image resolution, set camera target, set camera position #109
rdeits merged 5 commits into
meshcat-dev:masterfrom
Simple-Robotics:feat/set-capture-resolution

ManifoldFR commented Jan 11, 2022 •

edited

Loading

Uh oh!

rdeits Mar 23, 2022

Uh oh!

ManifoldFR Apr 3, 2022

Uh oh!

codecov-commenter commented Apr 3, 2022 •

edited

Loading

Uh oh!

ManifoldFR commented Apr 20, 2022

Uh oh!

ManifoldFR commented Jul 3, 2022 •

edited

Loading

Uh oh!

ManifoldFR commented Nov 16, 2022 •

edited

Loading

Uh oh!

rdeits commented Apr 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ManifoldFR commented Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdeits Mar 23, 2022

Choose a reason for hiding this comment

Uh oh!

ManifoldFR Apr 3, 2022

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Apr 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ManifoldFR commented Apr 20, 2022

Uh oh!

ManifoldFR commented Jul 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ManifoldFR commented Nov 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdeits commented Apr 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ManifoldFR commented Jan 11, 2022 •

edited

Loading

codecov-commenter commented Apr 3, 2022 •

edited

Loading

ManifoldFR commented Jul 3, 2022 •

edited

Loading

ManifoldFR commented Nov 16, 2022 •

edited

Loading