Drop Java 7 support and add try methods#155
Merged
Conversation
Throwing exceptions is expensive and should generally be reserved for exceptional circumstances. This change adds to the DatabaseReader support for returning an Optional instead of an exception when the IP address is not found.
eilara
suggested changes
Oct 16, 2019
|
thank
| |
马新港
|
|
[email protected]
|
签名由网易邮箱大师定制
On 10/17/2019 05:05，Ran Eilam<[email protected]> wrote：
@eilara commented on this pull request.
In src/main/java/com/maxmind/geoip2/model/AbstractCityResponse.java:
@@ -33,7 +33,7 @@
this.city = city != null ? city : new City();
this.location = location != null ? location : new Location();
this.postal = postal != null ? postal : new Postal();
- this.subdivisions = subdivisions != null ? subdivisions : new ArrayList<Subdivision>();
+ this.subdivisions = subdivisions != null ? subdivisions : new ArrayList<>();
}
Right, misread that. So this is for In Java SE 7 and later, you can replace the type arguments required to invoke the constructor of a generic class with an empty set of type arguments (<>) as long as the compiler can ... (from jdk docs)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes #147.