Skip to content

fix(story): ensure that the Model Codecs are always registered #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbouffard merged 1 commit into from
Apr 5, 2025
Merged

fix(story): ensure that the Model Codecs are always registered #749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/html/.storybook/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
GlobalConfig,
NoOpLogger,
ObjectCodec,
registerModelCodecs,
resetEdgeHandlerConfig,
resetEntityRelationConnectorConfig,
resetHandleConfig,
Expand Down Expand Up @@ -54,9 +55,13 @@ const resetMaxGraphConfigs = (): void => {
// Reset registries to remove additional elements registered in a story
// The objects storing the registered elements are currently public, but they should not be part of the public API.
// They will be marked as private in the future and clear functions will probably provide instead.

// Codec resets
CodecRegistry.aliases = {};
CodecRegistry.codecs = {};
// This is done automatically by ModelSerializer but only once, even if the codec registry is cleaned. So force reload manually here.
// This is a workaround. If we had a unregisteredCodecs function, we could reset the global codecs loading status and the codecs would be automatically registered again.
registerModelCodecs(true);
ObjectCodec.allowEval = originalAllowEvalConfig.objectCodec;
StylesheetCodec.allowEval = originalAllowEvalConfig.stylesheetCodec;

Expand Down