Skip to content

chore(deps-dev): bump typescript-eslint from 7.18.0 to 8.29.0#744

Merged
tbouffard merged 1 commit intomainfrom
chore/bump_ts-eslint
Apr 3, 2025
Merged

chore(deps-dev): bump typescript-eslint from 7.18.0 to 8.29.0#744
tbouffard merged 1 commit intomainfrom
chore/bump_ts-eslint

Conversation

@tbouffard
Copy link
Copy Markdown
Member

@tbouffard tbouffard commented Apr 2, 2025 •
edited
Loading

For now, disable the "no-unsafe-function-type" rule. This requires a lot of changes which will probably will introduce breaking changes.
Enabling this rule will be done later.

Restore the automatic Dependabot update as the lint fixes related to v8 have been integrated, so it will be possible to follow recent updates.

Summary by CodeRabbit

  • Chores

    • Revised development configurations to improve code quality and ensure more consistent tooling.
    • Upgraded internal dependencies to leverage current enhancements in type checking and code analysis.

  • Refactor

    • Streamlined event handling logic for greater clarity and maintainability, ensuring that core interactions continue to work seamlessly.

@tbouffard
chore(deps-dev): bump typescript-eslint from 7.18.0 to 8.29.0
c17ccb7 
For now, disable the "no-unsafe-function-type" rule. This requires a lot of changes which will probably will introduce
breaking changes.
Enabling this rule will be done later.
@tbouffard tbouffard added dependencies skip-changelog Do not include in Changelog and Release Notes javascript Pull requests that update Javascript code labels Apr 2, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2025 •
edited
Loading

Walkthrough

This pull request introduces modifications to the project's linting configuration, dependency management, and a minor code refactor. New ESLint rules are added in the configuration file to handle specific TypeScript behaviors, and the dependency handling for @typescript-eslint/* has been updated in the Dependabot settings. Additionally, the versions of TypeScript linting tools have been upgraded and function assignment in the EventsMixin has been refactored for clarity.

Changes

Files Change Summary
.eslintrc.json, .github/dependabot.yml Added ESLint rules: @typescript-eslint/no-unsafe-function-type is disabled, and @typescript-eslint/no-unused-expressions is set to error with allowances; updated Dependabot to include @typescript-eslint/* in lint patterns instead of ignoring them.
package.json Upgraded @typescript-eslint/eslint-plugin and @typescript-eslint/parser from ~7.18.0 to ~8.29.0.
packages/core/src/view/mixins/EventsMixin.ts Refactored the code by separating the assignments of mouseMoveRedirect and mouseUpRedirect into distinct statements for improved clarity.

Sequence Diagram(s)

Possibly related PRs

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a46d707 and c17ccb7.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • .eslintrc.json (1 hunks)
  • .github/dependabot.yml (1 hunks)
  • package.json (1 hunks)
  • packages/core/src/view/mixins/EventsMixin.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build (windows-2022)
🔇 Additional comments (4)
package.json (1)

24-25: Version upgrade for typescript-eslint dependencies looks good.

The update from ~7.18.0 to ~8.29.0 for both @typescript-eslint/eslint-plugin and @typescript-eslint/parser aligns with the PR objectives. This is a major version upgrade that likely includes new features and improvements.

.eslintrc.json (1)

27-34: Configuration changes align with PR objectives.

The addition of these two rules is appropriate:

  1. Disabling no-unsafe-function-type matches the PR description about avoiding breaking changes.
  2. The no-unused-expressions rule configuration allows common JavaScript patterns like short-circuit evaluations and ternary expressions.
.github/dependabot.yml (1)

44-44: Appropriate dependency management update.

Moving @typescript-eslint/* from being ignored to being included in the lint patterns group is consistent with the typescript-eslint version upgrade. This will allow Dependabot to manage these dependencies going forward.

packages/core/src/view/mixins/EventsMixin.ts (1)

466-483: Improved code readability.

The refactoring of the function assignments improves code clarity by using separate statements instead of chaining them with the comma operator. This change maintains identical functionality while making the code more maintainable and easier to read.

This change likely helps comply with the updated linting rules from the typescript-eslint upgrade.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tbouffard tbouffard merged commit 2e575f4 into main Apr 3, 2025
7 checks passed
@tbouffard tbouffard deleted the chore/bump_ts-eslint branch April 3, 2025 06:04
@tbouffard tbouffard mentioned this pull request Apr 3, 2025
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies javascript Pull requests that update Javascript code skip-changelog Do not include in Changelog and Release Notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tbouffard