fix(story): convert page-breaks story to typescript and add missing imports#537
Merged
tbouffard merged 3 commits intomaxGraph:mainfrom Sep 23, 2024
Merged
fix(story): convert page-breaks story to typescript and add missing imports#537tbouffard merged 3 commits intomaxGraph:mainfrom
tbouffard merged 3 commits intomaxGraph:mainfrom
Conversation
tbouffard
reviewed
Sep 23, 2024
tbouffard
approved these changes
Sep 23, 2024
Member
tbouffard
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution 🏅
✔️ Tested locally with the artifact built by GH Actions
✔️ All checks pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
maxGraph, and you are assigned to the issue.packages/core/_tests_or a new or altered Storybook story inpackages/html/stories(an existing story may also demonstrate the change).Overview
I converted PageBreaks story to ts and add missing imports. Errors and warns caused by converting story to ts are removed.
Notes
Previously the "Print" button didn't work. Currently the button opens a new tab, but it doesn't show the vertices or edges, so it doesn't solve #535.