Skip to content

fix(story): convert page-breaks story to typescript and add missing imports#537

Merged
tbouffard merged 3 commits intomaxGraph:mainfrom
reuse-ay:fix-pagebreak
Sep 23, 2024
Merged

fix(story): convert page-breaks story to typescript and add missing imports#537
tbouffard merged 3 commits intomaxGraph:mainfrom
reuse-ay:fix-pagebreak

Conversation

@reuse-ay
Copy link
Copy Markdown

@reuse-ay reuse-ay commented Sep 21, 2024

PR Checklist

  • Addresses an existing open issue: just convert story to TS and add missing import. This is a first step for [BUG] PageBreak Story: "Print" does not work. #535
  • You have discussed this issue with the maintainers of maxGraph, and you are assigned to the issue.
  • The scope of the PR is small enough to review in a single session. PR targeting several issues should be split into separate PRs. Don't create large PR like Examples fixed #88.
  • I have added tests to prove my fix is effective or my feature works. This can be done in the form of automatic tests in packages/core/_tests_ or a new or altered Storybook story in packages/html/stories (an existing story may also demonstrate the change).
  • I have provided screenshot/videos to demonstrate the change. If no releavant, explain why.
  • I have added or edited necessary documentation, or no docs changes are needed.
  • The PR title follows the "Conventional Commits" guidelines.

Overview

I converted PageBreaks story to ts and add missing imports. Errors and warns caused by converting story to ts are removed.

Notes

Previously the "Print" button didn't work. Currently the button opens a new tab, but it doesn't show the vertices or edges, so it doesn't solve #535.

Comment thread packages/html/stories/PageBreaks.stories.ts Outdated
Copy link
Copy Markdown
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution 🏅
✔️ Tested locally with the artifact built by GH Actions
✔️ All checks pass

@tbouffard tbouffard added the bug Something isn't working label Sep 23, 2024
@tbouffard tbouffard merged commit a5820a6 into maxGraph:main Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants