Skip to content

chore: configure eslint #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbouffard merged 5 commits into from
Oct 23, 2022
Merged

chore: configure eslint #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89e644c
chore: configure eslint #122
mayorovad Oct 7, 2022
ec59cb8
chore: bump prettier to 2.7.1, add eslint-config-prettier, fix eslint…
mayorovad Oct 7, 2022
9b8f08d
chore: edit base tsconfig and extend packages tsconfig on it. Change …
mayorovad Oct 8, 2022
b0785c8
chore: revert tsconfig changes #123
mayorovad Oct 9, 2022
a27127e
Merge branch 'development' into eslint-init
tbouffard Oct 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
**/dist/**
**/node_modules/**
27 changes: 27 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"root": true,
"env": {
"browser": true,
"es2020": true
},
"plugins": [
"@typescript-eslint",
"eslint-plugin-import"
],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"prettier"
],
"rules": {
"no-misleading-character-class": "warn",
"no-dupe-else-if": "warn",
"no-warning-comments": "warn",
"import/no-absolute-path": "warn",

"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/ban-types": "off",
"@typescript-eslint/no-unused-vars": "off"
Comment on lines +22 to +25
Copy link
Copy Markdown

@Kurt29 Kurt29 Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these rules are just temporary?

Copy link
Copy Markdown
Author

@mayorovad mayorovad Oct 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, need to remove them after solving all unnecessary conditions warnings.

}
}
9 changes: 7 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
"dev": "node ./scripts/dev",
"bootstrap": "lerna bootstrap --no-ci",
"postinstall": "lerna bootstrap --no-ci",
"docs": "jsdoc -c jsdoc.json"
"docs": "jsdoc -c jsdoc.json",
"lint": "eslint packages/**/**.ts",
"lint:fix": "eslint --fix packages/**/**.ts",
"prettier": "prettier --write packages/*/src/**/*.ts"
},
"devDependencies": {
"@babel/core": "^7.16.0",
Expand All @@ -24,14 +27,16 @@
"@babel/preset-react": "^7.16.0",
"@babel/preset-typescript": "^7.16.0",
"@lerna/filter-options": "^4.0.0",
"@typescript-eslint/eslint-plugin": "^5.39.0",
"@typescript-eslint/parser": "^5.39.0",
"babel-loader": "^8.2.3",
"better-docs": "^2.3.2",
"cross-env": "~7.0.3",
"css-loader": "^6.5.1",
"file-loader": "^6.2.0",
"jsdoc": "^3.6.7",
"lerna": "^4.0.0",
"prettier": "^2.5.0",
"prettier": "^2.7.1",
"style-loader": "^3.3.1",
"typedoc": "^0.23.15",
"typescript": "^4.8.3",
Expand Down