Lock /createRoom calls#800
Merged
Merged
Conversation
To reduce the chance of multiple rooms being made in the same millisecond which makes v12 rooms unhappy as it causes the same room ID to be generated.
MadLittleMods
approved these changes
Sep 9, 2025
Collaborator
MadLittleMods
left a comment
MadLittleMods
left a comment
There was a problem hiding this comment.
Fine if you want to push forward with this direction
| @@ -14,6 +14,7 @@ import ( | |||
| "net/url" | |||
Collaborator
There was a problem hiding this comment.
To reduce the chance of multiple rooms being made in the same millisecond which makes v12 rooms unhappy as it causes the same room ID to be generated. This causes flakey tests on v12.
To be clear, the homeserver implementations prevent this (I assume) like Synapse with UNIQUE database constraints?
We're just wanting to workaround the problem of not complicating the tests from having to retry /createRoom requests.
Kinda feels like the homeserver implementations should be able to handle this gracefully.
Co-authored-by: Eric Eastwood <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce the chance of multiple rooms being made in the same millisecond which makes v12 rooms unhappy as it causes the same room ID to be generated. This causes flakey tests on v12.