You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is still a problem, though: the deprecation message says to switch to the toolkit. How is the user supposed to know how to do that? It's not in the mpl_toolkits part of the distribution.
Yes, but they are not toolkits that are being removed from mpl. The deprecation gives no clue as to where the new toolkit is, or even what it is called. Is it available anywhere other than via github? pip search cmocean shows that it exists under that name, and can be installed; pip search finance yields a long list, but I don't see anything that might be our finance toolkit.
Don't you think a user of finance.py might be puzzled upon seeing that deprecation message?
I'd indeed add the mpl_toolkits finance to pypi if it hasn't been done, to do a proper release. I can take care of this.
We've done something similar in slkearn, when we removed the hmm from sklearn and released it as a separate unmaintained project. There was not much confusion, but we did do a proper release and probably added a note somewhere to explain how to pip install it.
NelleV
changed the title
Silence deprecation warning when importing finance in pylab
[MRG+1] Silence deprecation warning when importing finance in pylab
Nov 28, 2016
QuLogic
changed the title
[MRG+1] Silence deprecation warning when importing finance in pylab
Silence deprecation warning when importing finance in pylab
Nov 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NelleV
changed the title
QuLogic
changed the title
The discussion is in #7295.
There is still a problem, though: the deprecation message says to switch to the toolkit. How is the user supposed to know how to do that? It's not in the mpl_toolkits part of the distribution.