[DO NOT MERGE]: maybe fix crossed keybindings in ipython 4.1#6053
Closed
tacaswell wants to merge 2 commits into
Closed
[DO NOT MERGE]: maybe fix crossed keybindings in ipython 4.1#6053tacaswell wants to merge 2 commits into
tacaswell wants to merge 2 commits into
Conversation
tacaswell
changed the title
Member
Author
|
This 'fixes' the jupyter problem by removing all the interaction with the jupyter keyboard manager. attn @Carreau |
Contributor
|
Ping @takluyver, @minrk and @jdfreder I'll try to have a look, but that will be hard in the next few days. @parleur you recently looked at the keyboard shortcut for vim/emacs/sublime keybindings. |
Member
Author
|
Any progress on this? Does the new widget fix this? |
Member
|
I believe it's fixed by the new widget but it would be good to fix this on 1.5.x/2.x too |
Member
Author
|
Do we have any idea what the underlying problem is? I am not even sure if this needs to be fixed on our side or the jupyter side. |
5 tasks
Member
Author
|
@Carreau Did you make any progress on this from the ipython side? |
Member
Author
|
replaced by #6752 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly fixes jupyter/notebook#949
attn @ericdill