backends: declare public API#4486
Conversation
There was a problem hiding this comment.
I thought that cmd_split wasn't used anywhere. But I'm probably wrong in trying to do too many things in this pull request. Maybe it's possible that users are depending on it?
|
The |
|
Maybe I'm misunderstanding this issue. We have forced every backend to declare Why don't just expose those "mandatory" names as public API instead of exposing each backend specific names? |
|
@fariza That is what I am thinking. The backend-specific backends will still be available via This will probably will break a fair amount of code, but I can't see how to warn people that are currently doing from bulk imports that are looking for backend specific classes. |
tacaswell
modified the milestones:
2.1 (next point release),
2.2 (next next feature release)
|
This PR looks to be moot now? Closing, but feel free to re-open if I'm in error.... |
7 participants
This is a successor request to #4363. It was decided that removing unused imports from the backends was bad for backwards compatibility. This time, we simply declare the public API via the
__all__module constant.