Conversation
QuLogic
reviewed
Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #31730.
Figure.figimage()creates aFigureImagewithout setting a transform. Its offsets are in pixels, so it only drew correctly because an unset transform defaults to identity. After.remove()andfig.add_artist(im),add_artistseesis_transform_set()is False and gives the imagetransSubfigure, so the image is drawn in the wrong place and doesn't show up.FigureImage.__init__now setsIdentityTransform()explicitly, which is what @rcomer suggested in the issue. This covers bothfigimage()and aFigureImagecreated directly, and atransform=kwarg still overrides it. The other half of the issue (draw order relative to the axes) was already fixed by #31746, so with both changes the remove/re-add cycle now draws correctly.AI Disclosure
I used Claude Code (generative AI) to trace the cause through
add_artist, draft the regression test, and help write this PR description (to make sure I am following standards).PR quality check
N/A for example/release notes/docs: this is a bug fix that makes an existing workflow behave as expected, with no API change.