FIX: use axis lines tight bbox within axis artist tight bbox#31628
Merged
Conversation
timhoffm
approved these changes
May 8, 2026
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
I'm also not an expert in axis artist, but the example looks simple enough.
Member
Author
|
Am I right in thinking bug fixes currently go in the 3.11 milestone? |
Member
|
I would say so because we'll do another release candidate. |
QuLogic
approved these changes
May 8, 2026
QuLogic
added a commit
that referenced
this pull request
May 8, 2026
QuLogic
added a commit
that referenced
this pull request
May 8, 2026
…628-on-v3.11.x Backport PR #31628 on branch v3.11.x (FIX: use axis lines tight bbox within axis artist tight bbox)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #31622. Since the axis lines appear to be clipped to the axes, we should use their tight bounding box instead of their window extent in their parent's tight bounding box. The code from the issue now gives
I welcome any guidance on whether there is a better/simpler example to use for the test. I am not familiar with axis artists.
AI Disclosure
None
PR checklist