Fix marker fillstyle rotation transform#31301
Open
jayaprajapatii wants to merge 1 commit intomatplotlib:mainfrom
Open
Fix marker fillstyle rotation transform#31301jayaprajapatii wants to merge 1 commit intomatplotlib:mainfrom
jayaprajapatii wants to merge 1 commit intomatplotlib:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31257
Problem
Updating the fillstyle of a marker using
Line2D.set_fillstyle()recreates the marker usingMarkerStyle(self._marker.get_marker(), fs). This drops existing attributes stored in the originalMarkerStyle, including the rotation transform. As a result, rotated markers lose their rotation after updating the fillstyle.Cause
set_fillstyle()constructs a newMarkerStylefrom the marker symbol. This discards internal attributes such as the transform that were present in the originalMarkerStyleinstance.Solution
Use the
MarkerStyle._with_attrs()factory method to construct the updated marker while preserving the attributes of the existing marker.This ensures that properties such as transform, joinstyle, and capstyle remain unchanged when updating the fillstyle.
Changes
Line2D.set_fillstyle()to useMarkerStyle._with_attrs()instead of constructing a newMarkerStyle.Result
Rotated markers now maintain their rotation when
set_fillstyle()is called, matching the expected behaviour described in the issue.