Skip to content

fix AxisLabel not picking up fontsize from set_ylabel in axisartist #31155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mr-Neutr0n wants to merge 1 commit into from
Closed

fix AxisLabel not picking up fontsize from set_ylabel in axisartist #31155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions lib/mpl_toolkits/axisartist/axis_artist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,9 @@ def __init__(self, *args, axis_direction="bottom", axis=None, **kwargs):
self._axis = axis
self._pad = 5
self._external_pad = 0 # in pixels
self._fontsize_from_default = True
LabelBase.__init__(self, *args, **kwargs)
self._fontsize_from_default = True
self.set_axis_direction(axis_direction)

def set_pad(self, pad):
Expand Down Expand Up @@ -377,6 +379,24 @@ def set_axis_direction(self, d):
self.set_default_alignment(d)
self.set_default_angle(d)

def set_fontsize(self, fontsize):
# docstring inherited
self._fontsize_from_default = False
super().set_fontsize(fontsize)

set_size = set_fontsize

def get_fontsize(self):
# docstring inherited
if self._fontsize_from_default and self._axis is not None:
try:
return self.get_ref_artist().get_fontsize()
except (IndexError, AttributeError):
pass
return super().get_fontsize()

get_size = get_fontsize

def get_color(self):
return self.get_attribute_from_ref_artist("color")

Expand Down
18 changes: 18 additions & 0 deletions lib/mpl_toolkits/axisartist/tests/test_axislines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,3 +146,21 @@ def test_subplotzero_ylabel():
ax.axis["left", "right", "bottom", "top"].set_visible(False)

zero_axis.set_axisline_style("->")


def test_label_fontsize_from_axes():
"""Test that AxisLabel inherits fontsize from the underlying axis label."""
fig = plt.figure()
ax = Subplot(fig, 1, 1, 1)
fig.add_subplot(ax)

# set_ylabel with fontsize should propagate to AxisLabel
ax.set_ylabel("Test", fontsize=20)
assert ax.axis["left"].label.get_fontsize() == 20

ax.set_ylabel("Test", fontsize=14)
assert ax.axis["left"].label.get_fontsize() == 14

# explicit set_fontsize on AxisLabel should override
ax.axis["left"].label.set_fontsize(30)
assert ax.axis["left"].label.get_fontsize() == 30
Loading