MNT: Remove unused eventson context from artist property update#31060
Merged
Conversation
The attribute `eventson` was introduced in 79aa291. While it was set on and off in various places, there has never been any code that made logic depend on its state. The attribute itself was removed in matplotlib#18910, but its toggling through the context manager was overlooked there. Note: There is another `eventson` in widgets.py, which is completely independent on this here, because widgets are not Artists.
timhoffm
commented
Feb 2, 2026
| property name for "{prop_name}". | ||
| """ | ||
| ret = [] | ||
| with cbook._setattr_cm(self, eventson=False): |
Member
Author
There was a problem hiding this comment.
The diff looks larger than it is. It's really just the removal of this line and unindenting the subsequent block.
scottshambaugh
approved these changes
Feb 2, 2026
QuLogic
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute
eventsonwas introduced in 79aa291. While it was set on and off in various places, there has never been any code that made logic depend on its state. The attribute itself was removed in #18910, but its toggling through the context manager was overlooked there.Fun fact: This temporary setting of
eventsonnever had any effect, but it was maintained through several refactorings of the property update mechanism. 🤯Note: There is another
eventsonin widgets.py, which is completely independent on this here, because widgets are not Artists.