Skip to content

PERF: Skip kwargs normalization in Artist._cm_set #31000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 5 commits into from
Feb 3, 2026
Merged

PERF: Skip kwargs normalization in Artist._cm_set #31000

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4509d47
Add fast path to artist._cm_set
scottshambaugh Jan 19, 2026
463167a
Skip normalize_kwargs
scottshambaugh Jan 20, 2026
9a9722f
Simplify _cm_set fast path
scottshambaugh Feb 2, 2026
56798e1
Docstring update
scottshambaugh Feb 2, 2026
17125fc
Apply suggestions from code review
scottshambaugh Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/matplotlib/artist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,14 +1292,17 @@ def set(self, **kwargs):
@contextlib.contextmanager
def _cm_set(self, **kwargs):
"""
`.Artist.set` context-manager that restores original values at exit.
A context manager to temporarily set artist properties.

In contrast to `.Artist.set` and for performance, this skips the
`normalize_kwargs` check.
"""
orig_vals = {k: getattr(self, f"get_{k}")() for k in kwargs}
try:
self.set(**kwargs)
self._internal_update({k: kwargs[k] for k in orig_vals})
yield
finally:
self.set(**orig_vals)
self._internal_update(orig_vals)

def findobj(self, match=None, include_self=True):
"""
Expand Down
Loading