MNT: Change default name of ListedColormaps#30532
Conversation
from "from_list" to "unnamed", which makes more sense logically. While technically a breaking change, I anticipate that nobody is relying on that default value.
timhoffm
force-pushed
the
listedcolormap-name
branch
from
2a8c8e0 to
2dd8175
Compare
Co-authored-by: Elliott Sales de Andrade <[email protected]>
|
The one failure is #30534 , not going to re-run tests to verify that the fix merged to main fixes this before merging. |
|
I have some reservations, but on balance I am 👍🏻 on this change. |
|
Trying to confirm my "nobody would rely on this rather brittle information" assumtion, I found one actual usage: and two likely out-of date usages (repo not updated for two 2 years) https://github.com/jasperroebroek/geomappy/blob/4fbf41f52befd0155a071d6558f2d0549e0c7454/tests/test_classified_params.py#L10 What does this mean? Should we a. revert and leave this be or |
|
I think option C. In the first one it looks like the check is a bit redundant anyway and the other two are in tests so it will affect developers, but not their users. |
3 participants
from "from_list" to "unnamed", which makes more sense logically.
While technically a breaking change, I anticipate that nobody is relying
on that default value.
Part of #29141.