ENH: Add support for per-label padding in bar_label by brifore13 · Pull Request #29696 · matplotlib/matplotlib

brifore13 · 2025-03-02T00:01:50Z

PR summary

PR checklist

[X ] "closes [ENH]: Allow list of padding values for bar_label #29647 " is in the body of the PR description to [(https://github.com/[ENH]: Allow list of padding values for bar_label #29647)]
[ X] new and changed code is tested
[X ] Plotting related features are demonstrated in an example
New Features and API Changes are noted with a directive and release note
[ X] Documentation complies with general and docstring guidelines

Implement support for array-like padding in bar_label. This allows users to specify different padding values for individual labels by passing an array-like object to the padding parameter. Updated the docstring to reflect acceptance of float or array-like of correct length. Ex: ax.bar_label(bars, padding=[3, 3, 3, 15])

github-actions

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

rcomer

Please also add unit tests to verify that the new behaviour does what you intend.

rcomer · 2025-03-02T10:51:50Z

-        for bar, err, dat, lbl in itertools.zip_longest(
-                bars, errs, datavalues, labels
+        try:
+            if not isinstance(padding, (str, bytes)) and np.iterable(padding):


I do not think it is necessary to check for string or bytes object here. Currently we assume the user correctly passed a float, so I think in future we can assume they correctly passed a float or iterable.

Thanks @rcomer, currently making the corrections and will add unit tests. This is my first PR request, so thank you for your help and patience.

Thanks @brifore13, if you need any help, feel free to ask questions here. Or you may prefer to ask them in our incubator gitter room.

rcomer · 2025-03-02T10:54:42Z

+                if len(padding_array) != len(bars):
+                    raise ValueError(
+                        f"padding must be of length {len(bars)} when passed as a sequence")
+                padding_list = list(padding_array)


The array will work fine in zip_longest, so we do not need to convert this to a list.

rcomer · 2025-03-02T10:57:18Z

+            else:
+                # single value, apply to all labels
+                padding_list = [padding] * len(bars)
+        except (TypeError, ValueError):


This will catch the ValueError you added for the wrong length iterable. I do not think you meant to do that.

rcomer · 2025-03-02T10:58:32Z

+                # single value, apply to all labels
+                padding_list = [padding] * len(bars)
+        except (TypeError, ValueError):
+            # not iterable or wrong length, use scalar padding


you already handled the "not iterable" case with the else on line 2948.

rcomer · 2025-03-02T12:26:42Z

The type hint will also need updating

matplotlib/lib/matplotlib/axes/_axes.pyi

Line 271 in 03b74ea

padding: float = ...,

story645 · 2025-03-04T12:00:25Z

try installing the pre-commit hooks to help spot and fix the pre-commit errors:

https://matplotlib.org/devdocs/devel/development_setup.html#install-pre-commit-hooks

Added unit testing for float and array-like processing. Modified logic based on requested changes. Updated type hint.

rcomer

Thanks @brifore13 I think this is looking in good shape now. I just have some minor comments on the change and you will also need to run boilerplate.py so that pyplot.bar_label gets updated too.

rcomer · 2025-03-06T17:39:44Z

-                bars, errs, datavalues, labels
+        if np.iterable(padding):
+            # if padding iterable, check length
+            padding_array = np.asarray(padding)


Suggested change

padding_array = np.asarray(padding)

padding = np.asarray(padding)

I suggest to just call this padding as it may end up an array or list and we don't mind which. It means we replace the original padding but that is OK since we were not going to need the original again.

rcomer · 2025-03-06T17:46:16Z

+    ax = plt.gca()
+    rects = ax.bar(xs, heights)


Suggested change

ax = plt.gca()

rects = ax.bar(xs, heights)

For efficiency, we can remove these lines and just reuse the original rects.

1. ran boilerplate.py 2. padding_array to padding 3. removed second rects in unit testing

timhoffm

This should get a What's New entry. See https://matplotlib.org/devdocs/users/next_whats_new/README.html

timhoffm · 2025-03-18T16:29:31Z

Thanks @brifore13, and congratulations on your first contribution to Matplotlib! 🎉 We'd welcome to see you back!

github-actions Bot reviewed Mar 2, 2025

View reviewed changes

rcomer requested changes Mar 2, 2025

View reviewed changes

Add unit tests and modified logic for bar_label padding

5bfa212

Added unit testing for float and array-like processing. Modified logic based on requested changes. Updated type hint.

melissawm added this to First Time Contributors Mar 5, 2025

melissawm moved this to Needs review in First Time Contributors Mar 5, 2025

rcomer reviewed Mar 6, 2025

View reviewed changes

rcomer added the New feature label Mar 7, 2025

rcomer added this to the v3.11.0 milestone Mar 7, 2025

Update pyplot, completed requested changes

f8985e2

1. ran boilerplate.py 2. padding_array to padding 3. removed second rects in unit testing

github-actions Bot added the topic: pyplot API label Mar 10, 2025

rcomer approved these changes Mar 10, 2025

View reviewed changes

timhoffm reviewed Mar 10, 2025

View reviewed changes

Comment thread lib/matplotlib/axes/_axes.py

Added a whats new entry

8fc5578

timhoffm reviewed Mar 18, 2025

View reviewed changes

Comment thread doc/users/next_whats_new/bar_label_padding_update.rst Outdated

Versionadded and more concise wording of whats new

fde2fa2

timhoffm approved these changes Mar 18, 2025

View reviewed changes

timhoffm reviewed Mar 18, 2025

View reviewed changes

Comment thread lib/matplotlib/axes/_axes.py Outdated

Fix whitespace

7f6fffe

timhoffm merged commit f730235 into matplotlib:main Mar 18, 2025

github-project-automation Bot moved this from Needs review to Waiting for author in First Time Contributors Mar 18, 2025

QuLogic moved this from Waiting for author to Merged in First Time Contributors Mar 18, 2025

	padding_array = np.asarray(padding)
	padding = np.asarray(padding)

Uh oh!

Conversation

brifore13 commented Mar 2, 2025

PR summary

PR checklist

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

rcomer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rcomer commented Mar 2, 2025

Uh oh!

story645 commented Mar 4, 2025

Uh oh!

rcomer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timhoffm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timhoffm commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants