DOC/TST: lock numpy < 2.1#28779
Merged
Merged
Conversation
Member
Author
|
Anyone should feel free to push changes to this, and/or merge. |
timhoffm
approved these changes
Sep 3, 2024
Member
Author
|
I'll self merge to unbreak doc builds. |
Member
|
@ksunden is talking with numpy if this is a intended or accidental change to numpy (the source of the problem is related to type coercion with I guess numpy 2.1.1 came out? |
Member
Author
|
Yes 2.1.1 is now out |
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recent numpy breaks
basic_units.py, which breaks the doc build.Someone should fix
basic_units.py, but for now, force version to be smaller than numpy 2.1