Repository navigation
Update type hints for font manager and extension - #26403
Merged
Merged
Conversation
Member
Author
|
I'm confused why I'm getting: because docs say that is in 4.6, for which I've bumped the requirements, and we've ended up with 4.7.1 installed. Maybe we need a newer |
Member
|
Mypy uses a vendored version of typeshed, which was synced to include So yes, I think a newer version of mypy is needed for this (>=1.4.0) Upgrading that will require ignoring the staticmethod problem that we pinned mypy for (which hasn't seen much traction upstream, though somebody else recently opened a similar issue, sooo) |
Member
Author
|
Hmm, well we didn't have |
ksunden
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Several setters allow
None, but are normalized so that the getter is not.For
ttf, theFontEntryweight may be anintinstead of astr.PR checklist