You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After I closed#25673 because the root cause of that issue is in IPython mapping "qt" to "qt5agg", I realized that perhaps we could still do better about our error message.
While this change would not have actually resolved the question of "what is asking this to be qt5??", it would have at least not also raised the question of "why is qt6 not working? It is installed."
Can we add a test? I think this is testable using the sub-process trick and doing sys.modules['PyQt5'] = None and so forth to ensure that a given binding is non-importable.
Can we add a test? I think this is testable using the sub-process trick and doing sys.modules['PyQt5'] = None and so forth to ensure that a given binding is non-importable.
The way Python importing works if you set the top level package to None in sys.modules then none of the sub-packages will be importable either. It would work to go all the way down to the ones we test, but they would not simulate "not installed" the same way blanking out the top level one would.
Added a test, put it in test_backends_interactive because that is where _run_helper is and other similar tests are located there (e.g. asserting that qt5agg actually uses qt5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
After I closed #25673 because the root cause of that issue is in IPython mapping "qt" to "qt5agg", I realized that perhaps we could still do better about our error message.
While this change would not have actually resolved the question of "what is asking this to be qt5??", it would have at least not also raised the question of "why is qt6 not working? It is installed."
Now only outputs the bindings which were actually tested, rather than all 4 regardless of whether only qt5 bindings were tested.
PR Checklist
Linked Issue
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst