Add legend handler for Annotation #23160
Draft
oscargus wants to merge 2 commits into
Draft
Conversation
oscargus
changed the title
oscargus
force-pushed
the
legendannotate
branch
3 times, most recently
from
5e1b5fe to
b2d38a2
Compare
Co-authored-by: Maged Hennawy <[email protected]>
3 tasks
|
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Turned out to be very hard to rebase #13034 so I've cherry-picked the relevant commits and fixed the style comments. Edit: realized that #13034 was heavily based on #10688 so I've added @magedhennawy as coauthor as well.
Closes #13034
Fixes #8236
A problem here is when an annotation is added, but no arrow is given, it will break. Not sure what is expected to happen in this case. Providing a better exception is easy, something like "An annotation must have an arrow if a label is provided" while creating the annotation, but maybe better to get an empty patch in the legend?Adding an annotation with a label, but no arrow will lead to an empty patch. In #13034 it was not handled (gave an error).
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).